[MIRROR] makes verb callbacks not execute if the original client disconnected #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnected [MDB IGNORE] (#25287) * makes verb callbacks not execute if the original client disconnected (#79964) ## About The Pull Request currently verb callbacks still execute if the usr at the time of their creation got deleted or had their client disconnected before they got invoked. this can cause issues if the verb being deferred assumes usr exists, now the callback will return instead of calling its proc if its invoked after usr is deleted or disconnected. ## Why It's Good For The Game less runtimes ## Changelog :cl: code: verb callbacks will no longer execute if the original client disconnected /:cl: --------- Co-authored-by: san7890 <the@ san7890.com> * makes verb callbacks not execute if the original client disconnected --------- Co-authored-by: Kylerace <[email protected]> Co-authored-by: san7890 <the@ san7890.com>
AnywayFarus
added a commit
that referenced
this pull request
Nov 28, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 9, 2024
… be closed (#861) * [Fix] Visually closing fakewalls when in fact they shouldn't be closed (#81353) ## About The Pull Request Moves update_appearance() proc further after checking if it can be closed. It was possible to stand inside an open falsewall, try to close it only for it to "close" visually and don't change any properties. ## Why It's Good For The Game Less bugs is good. No more fake-closed falsewalls. ## Changelog :cl: fix: Now falsewalls visually don't close when they shouldn't. /:cl: * [Fix] Visually closing fakewalls when in fact they shouldn't be closed --------- Co-authored-by: larentoun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25287
Original PR: tgstation/tgstation#79964
About The Pull Request
currently verb callbacks still execute if the usr at the time of their creation got deleted or had their client disconnected before they got invoked. this can cause issues if the verb being deferred assumes usr exists, now the callback will return instead of calling its proc if its invoked after usr is deleted or disconnected.
Why It's Good For The Game
less runtimes
Changelog
🆑 Kylerace
code: verb callbacks will no longer execute if the original client disconnected
/:cl: